By Developers, For Developers
PDF Pg | Paper Pg | Type | Description | Fixed on | Comments |
---|---|---|---|---|---|
7 | TYPO | Fifth line from top of page. Capybara config file not embedded. Missing closing quote on filename? | 2016-08-28 | ||
119 | TYPO | There is a space between remote_id: and string in this command. There shouldn’t be :). rails generate model subscription user:references \\ | 2016-08-28 | ||
117 | SUGGEST | 1.send(interval).from_now(date) Love how you did end_date_from. I have 1 idea for an improvement. I think it would be helpful to include `interval_count` in the model. Then could be used here instead of `1`. This method is currently only accurate if the count is 1. :) | 2016-08-28 | Yeah, let me take that as a something to fix in the text or at least call out as a limitation. | |
32 | TYPO | Contains the line “and the cost if it the found out by some miscreant…” in the second full paragraph | 2016-08-28 | ||
187 | TYPO | Rogue question mark in first sentence of second paragraph of “Keeping Data Secure” : “Not only do our administrators? have the ability to set a price…” | 2016-09-13 | ||
127 | SUGGEST | Love the webhooks chapter. While implementing on my own, 1 thing I added is http basic auth. Maybe useful to add in the chapter/controller example as well. I added this to the controller: | |||
3 | TYPO | The gem we’re adding to our gemfile is called money-rails: | |||
31 | TYPO | In the generated create_payments migration file (server_charge/01/db/migrate/20160721043026_create_payments.rb), the line that adds the index should read- | |||
112 | ERROR | Project: code/failure/01 rspec ./spec/workflows/purchases_cart_via_stripe_spec.rb:70 # PurchasesCartViaStripe an unsuccessful credit card purchase updates the ticket status ############################################### Randomized with seed 36256 PurchasesCartViaStripe Failures: 1) PurchasesCartViaStripe an unsuccessful credit card purchase updates the ticket status 1.1) Failure/Error: self.payment = Payment.create!(payment_attributes) #<Payment(id: integer, user_id: integer, price_cents: integer, price_currency: string, status: integer, reference: string, payment_method: string, response_id: string, full_response: json, created_at: datetime, updated_at: datetime) (class)> received :create! with unexpected arguments Please stub a default value first if message might be received with other args as well. 1.2) Failure/Error: payment.create_line_items(tickets) NoMethodError: 2) PurchasesCartViaStripe successful credit card purchase updates the ticket status 2.1) Failure/Error: self.payment = Payment.create!(payment_attributes) #<Payment(id: integer, user_id: integer, price_cents: integer, price_currency: string, status: integer, reference: string, payment_method: string, response_id: string, full_response: json, created_at: datetime, updated_at: datetime) (class)> received :create! with unexpected arguments Please stub a default value first if message might be received with other args as well. 2.2) Failure/Error: payment.create_line_items(tickets) NoMethodError: Finished in 0.27931 seconds (files took 2.69 seconds to load) Failed examples: rspec ./spec/workflows/purchases_cart_via_stripe_spec.rb:70 # PurchasesCartViaStripe an unsuccessful credit card purchase updates the ticket status Randomized with seed 36256 | |||
30 | ERROR | The text says : “will need both a database table and a resources :purchase line in the shouldn’t it be : “will need both a database table and a resources :payment line in the | |||
15 | SUGGEST | There seems to be an extraneous link in the shopping_cart.rb code example in the tickets_by_performance method - t.performance.id is a link and shouldn’t be; I clicked on it by accident :P |